Code Review

Overview

When run {site} prerender is triggered via Slack, the prerender audit now detects this via auditContext.slackContext.channelId and uses a simplified strategy: organic + included URLs only, skipping agentic URL sources and daily batching. Scheduled runs are unaffected.

Code Quality & Readability

src/prerender/handler.js

1. Variable pre-declaration block is a readability concern (around the isSlackTriggered branch):

   let finalUrls;
   let filteredCount;
   let agenticUrlsCount = 0;
   let currentAgentic = 0;
   let currentOrganic;
   let currentIncludedUrls;
   let isFirstRunOfCycle;

   Six let declarations before an if/else is a code smell. The Slack path and scheduled path are divergent enough to warrant extraction into separate helper functions (e.g., buildSlackTriggeredBatch(...) / buildScheduledBatch(...)), which would eliminate these shared mutable vars and make each path self-contained.

2. isNotRecentUrl moved up — relocated from after importTopPages to just after getRecentlyProcessedPathnames. Improves logical proximity. No correctness issue.

3. Minor: cleaner siteId — siteId: site.getId() → siteId (already destructured above). Clean.

4. Log message formatting fixed — the multi-line log had a leading newline before prerender_submit_scraping_metrics:. Good cleanup.

Potential Issues / Regressions

🚨 Critical gap: fallback path in processContentAndGenerateOpportunities not guarded

The spec explicitly states:

Step 3 fallback path: skips agentic fetch when mode === 'organic'

But the diff only changes a comment in step 3 — the actual getTopAgenticUrls() call in the fallback is not gated on isSlackTriggered. If a Slack-triggered run produces zero scrape results, the fallback will still fetch agentic URLs — contradicting the intent. This is a bug.

Removed metric: agenticNewThisCycle

The previous log included agenticNewThisCycle=${filteredAgenticUrls.length} — the count of agentic URLs new in this cycle. This was replaced with isSlackTriggered. If anyone is parsing this log field for monitoring/alerting, it's a silent regression worth noting.

Spec/implementation mismatch

The design doc (2026-04-06-prerender-organic-mode-design.md) describes using MODE_ORGANIC = 'organic' driven by explicit {"mode":"organic"} in the SQS message data (like MODE_AI_ONLY). The actual implementation diverged to use Slack context detection instead. The spec is now stale/misleading and should be updated to reflect the actual approach, or removed.

Test Coverage

Tests added cover:

• ✅ Slack-triggered: organic URLs included even when "recently processed"
• ✅ Slack-triggered: agentic URLs NOT fetched
• ✅ Scheduled: agentic URLs still fetched

Missing test: The fallback path in processContentAndGenerateOpportunities for Slack-triggered runs is not tested (and as noted above, the code doesn't guard it either).

Summary

Recommendation: Block on the step 3 fallback gap. The rest can be addressed or accepted as follow-up.